Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WordPress] Suggest the Performance Lab plugin where applicable #84

Open
rviscomi opened this issue Jun 15, 2022 · 4 comments
Open

[WordPress] Suggest the Performance Lab plugin where applicable #84

rviscomi opened this issue Jun 15, 2022 · 4 comments

Comments

@rviscomi
Copy link
Member

A number of WordPress-specific audit messages include a link to the search results page at wordpress.org/plugins. Now that the WordPress Performance working group has built the Performance Lab plugin, I'd like to see Lighthouse making a more opinionated recommendation to use that specific plugin where applicable.

For example, the modern-image-formats audit has a WordPress stack pack message of:

Consider using a plugin or service that will automatically convert your uploaded images to the optimal formats.

The Performance Lab plugin promotes a module that does exactly that:

WebP Uploads: Creates WebP versions for new JPEG image uploads if supported by the server.

cc @adamsilverstein @felixarntz @ThierryA

@felixarntz
Copy link

@rviscomi I think that's a great idea. You're also right in that the modern-image-formats would be precisely the audit where that would probably make the most sense. Right now we don't yet have other modules in the plugin that directly address specific Lighthouse audits (most other modules are about providing "Site Health" diagnostics in the WP Admin UI).

What would it entail to add this recommendation for the modern-image-formats audit? I think we should start with that for now, and then as further modules land in the plugin that map to certain audits, we can expand.

@rviscomi
Copy link
Member Author

It'd just entail a PR to modify this line:

'modern-image-formats': "Consider using a [plugin](https://wordpress.org/plugins/search/convert+webp/) or service that will automatically convert your uploaded images to the optimal formats.",

@brendankenny
Copy link
Member

PRs very welcome!

@ThierryA
Copy link

Excellent idea, I am very supportive of this indeed! I would also expect future recommendations to be added to other UIStrings as more modules are added to the Performance Lab plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants