-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add measures and logging for LCP diagnostics #112
Comments
Should be easy enough to edit this code after #115 is merged: web-vitals-extension/src/browser_action/vitals.js Lines 227 to 233 in dd624b9
To do similar to what INP does, using the attribution breakdown data: web-vitals-extension/src/browser_action/vitals.js Lines 239 to 266 in dd624b9
However currently the extension uses the normal build, so ideally we'd move to the attribution build to get this. Anyone any concerns with this? I think it's a small bit extra processing, but will give us better data. |
The Optimize LCP guide describes how to instrument DevTools with additional LCP diagnostic info. It neatly logs each diagnostic in a table and uses
performance.measure()
to show them in the Performance panel.Figure out whether upgrading to the attribution build in #110 is sufficient for logging the diagnostics, or whether we should add any extra table formatting like the example in the guide.
The
measure
feature should be gated behind the same User Timings option used by INP.The text was updated successfully, but these errors were encountered: