Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Unable to locate stylesheet #106

Closed
echolimazulu opened this issue Jul 1, 2022 · 5 comments
Closed

Unable to locate stylesheet #106

echolimazulu opened this issue Jul 1, 2022 · 5 comments

Comments

@echolimazulu
Copy link

echolimazulu commented Jul 1, 2022

Hello @developit and other contributors,

Thanks to you and the contributors of this project for a job well done.

While working with the critters-webpack-plugin project on macOS, I found that the this.compilation argument was probably redundant, resulting in an exception:

sheet = await this.readFile(this.compilation, filename);

I can assume that this is a bug, since readFile:

readFile(filename: string): Promise<string> | string;
readFile(filename) {

When the specified argument is removed, the assembly works properly.

Plugin version is 3.0.2., Webpack version is 5.

@janicklas-ralph
Copy link
Collaborator

That makes sense to me. Could you open a PR with those changes and I can merge

@echolimazulu
Copy link
Author

@janicklas-ralph Good morning Janicklas,

Thank you for your attention to this issue.

Please give me some time so that I can take a closer look at this issue, after which I can offer a PR.

@echolimazulu
Copy link
Author

@janicklas-ralph Hello,

I did some more research on this problem and found out its cause. Within one day, I plan to provide a solution (in a PR) and the necessary test, due to the lack of which this problem was not detected earlier.

@echolimazulu
Copy link
Author

echolimazulu commented Jul 8, 2022

@janicklas-ralph Good evening,

Please check out the solution I provided in PR: #110

@kara
Copy link
Collaborator

kara commented Oct 25, 2024

Closing this issue because ownership of Critters has moved to the Nuxt team, who will be maintaining the project going forward. This repo is archived and won't receive any future updates.

If the issue is still relevant, please re-post it to the actively-maintained fork at https://github.com/danielroe/beasties.

@kara kara closed this as completed Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants