Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for preload links with fetchpriority=high in analyze-loading-optimization #144

Open
westonruter opened this issue Jul 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@westonruter
Copy link
Collaborator

The analyze-loading-optimization command doesn't currently account for fetchpriority=high being added for images via preload links:

// Obtain fetchPriorityCount, lcpImageMissingFetchPriority, fetchPriorityInsideViewport, and fetchPriorityOutsideViewport.
const fetchpriorityHighImages = document.body.querySelectorAll(
'img[fetchpriority="high"]'
);
for ( const img of fetchpriorityHighImages ) {
analysis.fetchPriorityCount++;
if ( isElementInViewport( img ) ) {
analysis.fetchPriorityInsideViewport++;
} else {
analysis.fetchPriorityOutsideViewport++;
}
}

This is done by the Image Prioritizer plugin especially when the same image is not LCP on mobile and desktop, as in this case adding fetchpriority=high could be incorrect for one or the other.

@westonruter westonruter added the enhancement New feature or request label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant