-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add deployment of nvidia nim #803
base: mlp-base-dev
Are you sure you want to change the base?
feat: add deployment of nvidia nim #803
Conversation
For the repo, we try and follow the Terraform on Google Cloud: Best practices for general style and structure, could you take a look at it and update the PR. Mainly around the Adopt a naming convention and using underscore to delimit multiple words. Although not required, it is good practice to break out standard attributes and block attributes as well as alphabetize attributes in resources and data sources to make merges and updates from multiple people cleaner. Also please ensure that you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also see my prior comment.
@@ -0,0 +1,3 @@ | |||
output "inference-url" { | |||
value = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this isn't going to be populated with a value, can you remove it?
|
||
resource "kubernetes_storage_class" "name" { | ||
metadata { | ||
name = "hyperdisk-ml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is HDML required or could another StorageClass also be used?
Could you also include a |
You will also need to add the license header to your .tf files. |
How different is this from the nim guide that we merged into https://github.com/GoogleCloudPlatform/ai-on-gke/tree/main/tutorials-and-examples/nvidia-nim? |
Looks to be similar, except done with Terraform. We are consuming this in the |
Adding deployment of NVIDIA NIMs on the ML platform