Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove psycopg from requirements-test.txt until psycopg 2.9.10 is supported on Python 3.13 #388

Closed
rhatgadkar-goog opened this issue Nov 1, 2024 · 0 comments · Fixed by #407
Closed

Remove psycopg from requirements-test.txt until psycopg 2.9.10 is supported on Python 3.13 #388

rhatgadkar-goog opened this issue Nov 1, 2024 · 0 comments · Fixed by #407
Assignees
@rhatgadkar-goog
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@rhatgadkar-goog
Copy link
Collaborator

rhatgadkar-goog commented Nov 1, 2024 •
edited
Loading

Feature Description

psycopg 2.9.10 isn't supported on Python 3.13 for Windows yet: psycopg/psycopg2#1736. Until it gets supported, we should do the following:

  • Remove psycopg from requirements-test.txt
  • move test_psycopg2_direct_connection.py into docs/samples folder for now.

Also, psycopg 2.9.10 isn't supported on Python 3.9 for macos-14. So when we decide to add psycopg back into requirements-test.txt, we should only have tests run under macos-12, instead of macos-latest: https://github.com/GoogleCloudPlatform/alloydb-python-connector/blob/main/.github/workflows/tests.yaml#L40

Sample code

No response

Alternatives Considered

No response

Additional Details

No response
@rhatgadkar-goog rhatgadkar-goog added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 1, 2024
@rhatgadkar-goog rhatgadkar-goog mentioned this issue Nov 1, 2024
Merged
@enocom enocom added type: cleanup An internal cleanup or hygiene concern. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 5, 2024
rhatgadkar-goog added a commit that referenced this issue Nov 6, 2024
@rhatgadkar-goog
feat: add support for Python 3.13 (#383)
22ef77c 
This change adds support for Python 3.13. It does the following:
- The latest Python version that presubmit tests use is now Python 3.13, instead of Python 3.12.
- Remove `psycopg2-binary` package from `requirements-test.txt`, because Python 3.13 requires psycopg version 2.9.10. But 2.9.10 is not yet fully supported on Windows and Mac. As a result, we cannot run [test_psycopg2_direct_connection.py](https://github.com/GoogleCloudPlatform/alloydb-python-connector/pull/383/files#diff-58b933e0c009174fe693b297def131f462f39e29de5b887468865f45efb5dea8) as part of our presubmit tests. So we move it to the `docs/samples/` folder for now. Re-adding `psycopg2-binary` package and `test_psycopg2_direct_connection.py` to our presubmit tests is being tracked in #388.
@rhatgadkar-goog rhatgadkar-goog linked a pull request Jan 6, 2025 that will close this issue
chore: Add psycopg 2.9.10 into requirements-test.txt #407
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhatgadkar-goog rhatgadkar-goog

Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Add psycopg 2.9.10 into requirements-test.txt GoogleCloudPlatform/alloydb-python-connector
2 participants
@enocom @rhatgadkar-goog