-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
githubissues notifier - use single notifier for multiple repositories #189
Comments
…tion to allow using single notifier for multiple repositories
… that contains both user/org and repo name Doc: https://cloud.google.com/build/docs/configuring-builds/substitute-variable-values#using_default_substitutions
…revious logic doesn't work
Hi, I just reviewed that PR, hopefully that resolves this issue? |
… repo name is not set
@prabenzom Yes, indeed. I created this issue to surface the problem in case and used to track the PR in case someone search for the same feature |
@prabenzom I have another commit to automatically set the assignee to the GitHub issue based on commit info. The added complexity is Cloud Build context itself doesn't contain this information and I have to look up via an additional call to GH API. Is that something you would want to introduce in the upstream version? If yes, I'm more than happy to open another PR for it. |
Also want to ask: I saw someone threw the idea of having community-contributed notifier in the past, is that still on the radar? |
feat(#189): Infer github repo from build's information to allow using…
…tion to allow using single notifier for multiple repositories
… that contains both user/org and repo name Doc: https://cloud.google.com/build/docs/configuring-builds/substitute-variable-values#using_default_substitutions
…revious logic doesn't work
… repo name is not set
Current configuration only allows a single repository
In a larger scale where teams work on multiple repositories, it is undesirable to deploy multiple Cloud Run notifier for each individual repository (from both cost and maintenance perspective)
With a small tweak to use repository full name from Build's default substitutions value of
REPO_FULL_NAME
, we can deploy the notifier once and use it for multiple repositories.See default substitutions here: https://cloud.google.com/build/docs/configuring-builds/substitute-variable-values#using_default_substitutions
The text was updated successfully, but these errors were encountered: