Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

githubissues notifier - use single notifier for multiple repositories #189

Open
LeeU1911 opened this issue Feb 21, 2024 · 4 comments
Open

Comments

@LeeU1911
Copy link

LeeU1911 commented Feb 21, 2024

Current configuration only allows a single repository

      githubRepo: myuser/myrepo

In a larger scale where teams work on multiple repositories, it is undesirable to deploy multiple Cloud Run notifier for each individual repository (from both cost and maintenance perspective)

With a small tweak to use repository full name from Build's default substitutions value of REPO_FULL_NAME, we can deploy the notifier once and use it for multiple repositories.

See default substitutions here: https://cloud.google.com/build/docs/configuring-builds/substitute-variable-values#using_default_substitutions

VuKrampHub added a commit to kramphub/cloud-build-notifiers that referenced this issue Feb 21, 2024
…tion to allow using single notifier for multiple repositories
VuKrampHub added a commit to kramphub/cloud-build-notifiers that referenced this issue Feb 28, 2024
@prabenzom
Copy link
Contributor

Hi, I just reviewed that PR, hopefully that resolves this issue?

VuKrampHub added a commit to kramphub/cloud-build-notifiers that referenced this issue Apr 3, 2024
@VuKrampHub
Copy link
Contributor

@prabenzom Yes, indeed. I created this issue to surface the problem in case and used to track the PR in case someone search for the same feature

@VuKrampHub
Copy link
Contributor

@prabenzom I have another commit to automatically set the assignee to the GitHub issue based on commit info. The added complexity is Cloud Build context itself doesn't contain this information and I have to look up via an additional call to GH API.

Is that something you would want to introduce in the upstream version? If yes, I'm more than happy to open another PR for it.

@VuKrampHub
Copy link
Contributor

Also want to ask: I saw someone threw the idea of having community-contributed notifier in the past, is that still on the radar?

Saaarah added a commit that referenced this issue May 17, 2024
feat(#189): Infer github repo from build's information to allow using…
khhini pushed a commit to khhini/cloud-build-notifiers that referenced this issue Oct 12, 2024
…tion to allow using single notifier for multiple repositories
khhini pushed a commit to khhini/cloud-build-notifiers that referenced this issue Oct 12, 2024
khhini pushed a commit to khhini/cloud-build-notifiers that referenced this issue Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants