Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entrypoint.bash is non-compliant with Shell Style Guide #611

Open
andrewpollock opened this issue Feb 15, 2023 · 0 comments
Open

entrypoint.bash is non-compliant with Shell Style Guide #611

andrewpollock opened this issue Feb 15, 2023 · 0 comments

Comments

@andrewpollock
Copy link

I was reviewing google/osv.dev#1017 which has a straight copy of entrypoint.bash from this repo, and it's not particularly compliant (or internally consistent) with https://google.github.io/styleguide/shellguide.html (see some of my comments on that PR).

You might like to do something about that.
@andrewpollock andrewpollock changed the title entrypoint.bash is non-compliant with entrypoint.bash is non-compliant with Shell Style Guide Feb 15, 2023
@andrewpollock andrewpollock mentioned this issue Feb 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewpollock