Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secure-cloud-run-core loadbalancer.tf and ssl_certificates input #265

Closed
massfords opened this issue Nov 26, 2024 · 1 comment · Fixed by #276
Closed

secure-cloud-run-core loadbalancer.tf and ssl_certificates input #265

massfords opened this issue Nov 26, 2024 · 1 comment · Fixed by #276

Comments

@massfords
Copy link

The logic for enabling the create_ssl_certificate input for the load balancer module is based on the generate_certificates_for_domains being empty.

For example:

  create_ssl_certificate          = length(var.ssl_certificates.generate_certificates_for_domains) == 0 ? true : false

I am trying to create a secure-cloud-run with an existing certificate and thus I am passing [] for generate_certificates_for_domains and passing the self links for ssl_certificates_self_links

During the deploy, I am getting an error:

The argument "certificate" is required, but no definition was found.

I don't want the load balancer to create a certificate and I am not providing material for the certificate nor a private key. Instead, I want to pass an existing ssl certificate.

I don't see a way to set this input value to false without modifying the secure-cloud-run-core module directly.

@apeabody
Copy link
Contributor

Thanks for the report @massfords!

create_ssl_certificate should only be used when providing a private_key and certificate, hence the observed error. I've opened a PR to address: #276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants