-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues working with kind and ko #9609
Comments
I did some digging into the code, and found the |
Got around that by allowing it with the resourceSelector config: resourceSelector:
allow:
- groupKind: ContainerSource.sources.knative.dev
image: [ .* ] |
So now the only blocker is the ko image not being loaded into kind if I use the automatic name from the ko template... plus the awful naming of said image. |
I'm also unable to get debug working. Doesn't appear that Skaffold is calling ko with the debug flag set (otherwise, ko would be wrapping delve into the image, which I can see it isn't). Edit: realised Skaffold is using an old version of ko that doesn't have the |
Expected behavior
When using the ko builder with my kind cluster, I should be able to:
Actual behavior
If I use the placeholder ko image name in
skaffold.yaml
, the image doesn't get loaded intokind
. It does get replaced in myknative-service.yaml
. It does not get replaced in myknative-containersource.yaml
. The generated image name is awful, i.e., if it wasko://company.com/very/long/path/to/our/code
, it comes out askind.local/project/company_com_very_long_path_to_our_code
.If I use a non-placeholder image name, such as "test-image", the image gets loaded into kind. It does get replaced in my
knative-service.yaml
, but doesn't in myknative-containersource.yaml
. This obviously interferes with ko which isn't suitable for my workflow.Information
Skaffold version: v2.13.2 (I think... latest using Cloud Code)
Operating system: Ubuntu 24.04.1 LTS using WSL2 on Windows 11 23H2
Installed via: Cloud Code
Contents of skaffold.yaml:
The text was updated successfully, but these errors were encountered: