Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better strategy for calculating HTTP/2 flow control window #8

Open
Gowee opened this issue Sep 12, 2023 · 0 comments
Open

Find a better strategy for calculating HTTP/2 flow control window #8

Gowee opened this issue Sep 12, 2023 · 0 comments

Comments

@Gowee
Copy link
Owner

Gowee commented Sep 12, 2023

A tight window limits bandwidth, while a loose window undermines the effectiveness of flow control, resulting in higher latency & jitter.

The current implementation (in dev branch) is ported from hyper, which appears to be nonoptimal.

Similar strategies are also used in other libraries:

Dotnet: https://github.com/dotnet/runtime/pull/54755/files
gRPC: https://github.com/grpc/grpc-go/blob/master/internal/transport/bdp_estimator.go
cURL: curl/curl@a4d8888
Chromium: https://source.chromium.org/search?q=kSpdySessionMaxRecvWindowSize&sq=
Nginx: https://github.com/nginx/nginx/blob/b489ba83e9be446923facfe1a2fe392be3095d1f/src/http/v2/ngx_http_v2.c#L244
Go: https://github.com/golang/net/blob/47caaff48d7cdfbc45b155988009eb57a72bbeaf/http2/server.go#L158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant