New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include MessagePort with event.data to remove a need to pass Events instances around #13

Open

Gozala opened this issue Feb 21, 2019 · 1 comment

Owner

Gozala commented Feb 21, 2019

This would address this TODO:

lunet/docs/lunet.js

Lines 54 to 56 in 84561e2

    
           // TODO: Fix up types. Problem is that we match on `data` which does not 
        
           // refine event which is what we need to refine instead. 
        
           const $event /*:any*/ = event

And also simplify bunch of code all around.

Owner Author

Gozala commented Feb 21, 2019

It might be worth tackling this with #7 as later might render this obsolete or at least have some overlap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment