Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespacing #21

Open
ebellempire opened this issue Jan 24, 2014 · 3 comments
Open

Namespacing #21

ebellempire opened this issue Jan 24, 2014 · 3 comments

Comments

@ebellempire
Copy link

I think more specific class names would really help with compatibility.

I've been trying to get around a name conflict (in the Omeka CMS, which also uses Item) using PHP's namespace to no avail.

For some reason, it's putting together the various book parts but the spine and manifest are empty, producing a corrupt file.

I'm not sure the best way to approach this (nor am I sure I'm using namespaces correctly) but figured I'd put it out there as an issue.

@Grandt
Copy link
Owner

Grandt commented Jan 24, 2014

Please send the corrupted ePub to [email protected]

Also, are you suggesting that I add a namespace to the PHPePub classes?

@Grandt
Copy link
Owner

Grandt commented Feb 5, 2014

Hi.

Apologies for taking a while to get back to you. Things got a little hectic for a while.

Please have a look at the 3.30 branch for the namespace fix. I've used \com\grandt

The problem was that I test for class names using get_class. It always returns the fully qualified class name within its namespace, meaning nothing was actually added to the OPF and NCX files.

@ebellempire
Copy link
Author

Fantastic, thank you! The method you applied to the 3.30 branch appears to solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants