Display only name instead of name with link for node in message details. #20505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
commented
Sep 20, 2024
| @@ -71,7 +71,6 @@ class MessageShow extends React.Component { | |||
| message={message} | |||
| inputs={inputs} | |||
| streams={streams} | |||
| nodes={nodes} | |||
| renderForDisplay={this.renderForDisplay} | |||
| showTimestamp /> | |||
There was a problem hiding this comment.
nodes are currently nod provided by components which implement this component.
I did not migrate it to TS, because I want to keep the backport simple.
linuspahl
commented
Sep 20, 2024
|
|
||
| nodeInformation = AppConfig.isCloud() | ||
| ? nodeContent | ||
| : <a href={nodeURL}>{nodeContent}</a>; |
There was a problem hiding this comment.
Here we were already considering the cloud env.
maxiadlovskii
approved these changes
Sep 23, 2024
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is fixing two problems:
Please note, this PR needs a backport for
5.2and6.0Fix #20464