Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GITHUB_REF_NAME not working #26

Closed
KlutzyBubbles opened this issue Dec 10, 2023 · 3 comments
Closed

GITHUB_REF_NAME not working #26

KlutzyBubbles opened this issue Dec 10, 2023 · 3 comments

Comments

@KlutzyBubbles
Copy link

my workflow is https://github.com/KlutzyBubbles/lc-better-emotes/blob/v1.0.3/.github/workflows/release.yml

No matter how i format the GITHUB_REF_NAME variable, it either inputs it as a literal string 'GITHUB_REF_NAME' or an empty string. I then reverted to trying the readme and it still says the inputted version is '$GITHUB_REF_NAME'.

While not a specific error with the action itself, i am looking for help with making this work.

@AnActualEmerald
Copy link
Member

That's kind of odd. You could try using the context instead: ${{ github.ref_name }} and see if that works. Maybe they changed something about how environment variables are processed in action inputs.

@KlutzyBubbles
Copy link
Author

That's kind of odd. You could try using the context instead: ${{ github.ref_name }} and see if that works. Maybe they changed something about how environment variables are processed in action inputs.

This seems to work fine, i was surprised i couldn't find any docs with that listed.

Quick question on a couple other things that are now stopping me, I originally got some warnings about repo not being a valid input (the example on the readme was still on v4 instead of v4.1)

I am now getting Status code: 400 BadRequest {"categories":{"1":["Object not found"],"2":["Object not found"]}} Exiting similar to #22 but nothing seems to fix it. Even trying with tcli 0.2.3 so pretty sure its not related to this action but wanted to link the issue i just created anyway thunderstore-io/thunderstore-cli#99

@AnActualEmerald
Copy link
Member

Yeah it looks like the workaround won't work in your case since lethal company doesn't have its own repo 🤔 that's something that will have to be addressed by the tstore team

In the meantime you can try leaving the categories empty in your workflow and add them manually on thunderstore once it's published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants