Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Backdrop does not appear properly when in OnPush change detection strategy #35

Open
joeflateau opened this issue Aug 13, 2018 · 3 comments
Labels

Comments

@joeflateau
Copy link

As the title states. If I have my app.component set to OnPush, then the backdrop does not appear until I click, resize or something else triggers the change detection. Are you open to PRs?

@meeroslav
Copy link
Collaborator

@joeflateau, I will look into it as soon as possible. I think @maaagik already has a solution proposal.

Sorry for the delay in the response. I was away from open source for a few months.

PR's are of course welcome

@meeroslav meeroslav added the bug label Nov 7, 2018
@joeflateau
Copy link
Author

@meeroslav no worries, if @maaagik's solution doesn't work out tag me and i'll send a PR

@rafaelss95
Copy link

I'm facing this issue right now. Any plans to solve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants