Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support different struct in WriteObject #25

Open
yuanbohan opened this issue Feb 27, 2024 · 0 comments
Open

support different struct in WriteObject #25

yuanbohan opened this issue Feb 27, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@yuanbohan
Copy link
Contributor

yuanbohan commented Feb 27, 2024

for now, ingester-go only support one type in Client.WriteObject, but it should behave like ingester-java, like:

resp, err := client.WriteObject(context.Background(), cup1, mem1, cup2, mem2)

Function signature

from

func (c *Client) WriteObject(ctx context.Context, obj any) (*gpb.GreptimeResponse, error) 

to

func (c *Client) WriteObject(ctx context.Context, objs ...any) (*gpb.GreptimeResponse, error) 

NOTE

  • To simplify the maintenance, WriteObject use variadic parameters
@yuanbohan yuanbohan added the good first issue Good for newcomers label Mar 16, 2024
@yuanbohan yuanbohan changed the title support multiple and different struct in WriteObject support different struct in WriteObject Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant