Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows wildcard queries for metric names in PromQL. #5375

Open
killme2008 opened this issue Jan 15, 2025 · 0 comments · May be fixed by #5385
Open

Allows wildcard queries for metric names in PromQL. #5375

killme2008 opened this issue Jan 15, 2025 · 0 comments · May be fixed by #5385
Assignees
Labels
C-enhancement Category Enhancements

Comments

@killme2008
Copy link
Contributor

killme2008 commented Jan 15, 2025

What type of enhancement is this?

API improvement

What does the enhancement do?

GreptimeDB currently supports only the equal matcher for metric names, such as {__name__ = 'up'}, and does not support other matchers like != or ~=.

For instance:

 count by(__name__)({__name__=~"go_.*"})

I believe GreptimeDB should also support regex(and not regex) matchers, but the != matcher will not be implemented due to performance concerns.

The regex matcher will query the tables from the metric engine's internal metadata, and join the results from each metric table to return the response. Of course, we must limit the table number to return at one time to avoid OOM error.

Implementation challenges

No response

@killme2008 killme2008 added the C-enhancement Category Enhancements label Jan 15, 2025
@killme2008 killme2008 self-assigned this Jan 15, 2025
@killme2008 killme2008 linked a pull request Jan 16, 2025 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category Enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant