Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The language doesn't change after you change the language of your settings in-game. #43

Open
4 tasks done
reamianv opened this issue May 12, 2024 · 3 comments
Open
4 tasks done
Assignees
Labels
bug Something isn't working

Comments

@reamianv
Copy link

reamianv commented May 12, 2024

Checklist

  • You are using official version downloaded from Blob Builds (blob.build) or Guizhan Builds (builds.guizhanss.com)
  • You have verified the checksum of the downloaded file to ensure it is complete (only for Guizhan Builds)
  • You did not modify the jar file
  • You searched existing issues, and could not find any existing bug report on this

Description

I was obviously using the ko: en mapping to translate and use the language, and when I changed the SlimeFun language from ko -> en, the ko language I was using before was not changed to en. So I tried changing the language in the Minecraft in-game settings from korean -> english, and the language setting in the SlimeFun guide from korean to english, but it didn't change to english. So I thought it was weird, so I tried setting it to a language other than english, but the language of the items that looked Korean didn't change even if I set it to another language.

To summarize, changing the language in the in-game , Slimefun settings does not change the language of the item to another language.

Reproduction Steps

  1. Language set After use command sf give Mcnick itemname
  2. Change the Slimefun guide language, and minecraft game language
  3. Check the item name. and lore
  4. ReJoin
  5. Check the item name and lore
  6. Server Reboot
  7. Check the item name and lore
  8. Delete the plugin and start the server
  9. join
  10. Check the item name and lore

Expected Behavior

Item Lore and names should display correctly when the language is set to a different language.

Server log

[Pastebin.com/KYKGebi7]

Error report

No response

Server Software

Purpur

Minecraft Version

1.20.1

Slimefun version

build 1145

Plugin version

build 21

@reamianv reamianv added the bug Something isn't working label May 12, 2024
@reamianv
Copy link
Author

2024-05-13_01 21 48
2024-05-13_01 22 57
2024-05-13_08 19 42
2024-05-13_08 24 41
2024-05-13_08 24 47
2024-05-13_08 35 22

@ybw0014
Copy link
Member

ybw0014 commented May 14, 2024

since the default translations only cover core slimefun items, you will need to contact the translation provider about the translation of addon items.
also, do not map other languages to English. Instead, change the server's default language in Slimefun config, and set player language to server default. (Minecraft language has no effect on this plugin)

@reamianv
Copy link
Author

As for translations, I'm slowly translating everything by hand (including additional addons) and haven't mapped other languages to English. In the Slimefun configuration, I've already set the default language of the server to ko.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants