Fix README snippet for adding registry #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for pointing out the mistake. I find the full syntax too annoying though so I'll just revert that part of #82. |
| @@ -43,8 +43,9 @@ The recommended way to create a registry is | |||
| using LocalRegistry | |||
| create_registry(name, repository_url; description = "My private registry", push = true) | |||
| ``` | |||
| where `name` is the name of your registry and `repository_url` points | |||
| to an *empty* upstream repository where you will host your registry. | |||
| where `name` is the name of your registry as a `String` and | |||
There was a problem hiding this comment.
What alternative is there to using a String?
There was a problem hiding this comment.
Maybe that was just because I was confused because the other example didn’t work, but it wasn’t entirely clear to me what these variables were supposed to be. E. g. repository_url could be a RegistrySpec, or some special URL type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small fix for the snippet showing how to add a registry using
PkginREADME.md.