Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of MaterialSideProfile creates invalid HTML (div in ul) #418

Open
Medo42 opened this issue Aug 26, 2020 · 2 comments
Open

Use of MaterialSideProfile creates invalid HTML (div in ul) #418

Medo42 opened this issue Aug 26, 2020 · 2 comments

Comments

@Medo42
Copy link

Medo42 commented Aug 26, 2020

Can be seen easily in https://gwtmaterialdesign.github.io/gwt-material-patterns/snapshot/#sidenav_push_header

The div.side-profile sits directly inside the ul.sidenavPushHeader. However, as far as I can tell, only li elements are allowed as children of ul elements.

Browsers largely don't seem to care about this restriction (after all, they have evolved in a wonderful world of broken websites that should still be presented as well as possible), but we're getting this flagged as an issue when inspecting our application for accessibility problems. It makes sense to me that some accessibility tools might not be as good at dealing with broken HTML as the major browsers, so it may be especially important in that area to ensure the HTML is valid.

@kevzlou7979
Copy link
Contributor

kevzlou7979 commented Sep 5, 2020

We have a new widget that holds Side Profile and it was MaterialSideContent.

@Medo42
Copy link
Author

Medo42 commented Apr 27, 2021

Where can I find information about this new widget? Which release is it contained in? Neither google nor github's search in this repository or the main gwt-material repository got me any helpful results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants