Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DataExtractors here? #2

Open
casaout opened this issue Oct 1, 2018 · 4 comments
Open

Move DataExtractors here? #2

casaout opened this issue Oct 1, 2018 · 4 comments
Assignees
@casaout @RaphaelRo
Labels
question Further information is requested

Comments

@casaout
Copy link
Member

casaout commented Oct 1, 2018

Does it make sense to move the data extractors here?
@casaout casaout added the question Further information is requested label Oct 1, 2018
@RaphaelRo
Copy link

I am not familiar with the Extractors but by the first look, it seems they are very specific to the database implementation? So imho not.

@casaout
Copy link
Member Author

casaout commented Oct 2, 2018

Sorry, I need to provide a bit more context ;) They basically take a window title, and extract things like File-Names, Website-Names, (sometimes) even People we collaborate with.

How we consume them is specific to the db; but we/I could extract the mapper. (Just yesterday, I had a conversation with someone, who is interested in using that part).

@RaphaelRo
Copy link

Oh thanks for the clarification. Yes - it makes sense then to put it into the package (assuming we can untangle it from the db without too much effort).

@casaout
Copy link
Member Author

casaout commented Oct 2, 2018

Yeah, I think we can. But that's probably something I should do 😯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casaout casaout

@RaphaelRo RaphaelRo

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@casaout @RaphaelRo