-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Voting on requests sends notifications for claims/fills #4105
Comments
PM's aren't really designed for this. All users including those that voted anonymously would be in the participant list. Although keeping a system user within the conversation will prevent any messages from being sent. I also think the existence of an Are notifications fine? |
I was not meaning add all to one at all, just putting them in one. Anon flag for PMs is good too, but would be under a different scope for the feature, as that would be under a way to use the "send uploader message" button on a torrent or even a request. That could have the option for keeping themselves anon as well if wanted, having the user getting the PM being anon based on if they made that torrent/request as anon.
Notifications in their current state really do not work for things like this. They would end up getting several notifications for the same thing, if they are used it needs to be just a generic "A request you voted on received an updated status." with the name there and it linking to the request, but not sending a new one while you have it unread. PMs work better for this because you can both keep updating without sending multiple notifications and having the ability to further send advice. The message could have information about reporting it too, which in a notification does not really fit space wise. A good example of why notifications wouldn't really work is forum topics that users watch, if you get 5 replies to a thread, you get 5 notifications rather than a single one with a counter or just the oldest taking you to the last read post. Threads are easily solved by people just unwatching it, a request would not really work for that. |
PMs are still not intended for this and would be an abuse of its threaded functionality. It'd be better for notifications to update their status. As far as I'm concerned, all system generated PMs are already an abuse of functionality and should ideally be notifications instead. |
I would think that only the requester gets to determine is a request is filled or unfilled. And personally I prefer notification, especially for something like being notified about request status for someone else's request, because it already has fine grained control over what is pinged. |
When someone votes on a request they should get the claim/fill.
This is important so they don't have to create a dupe request to get the notifications.
It also allows them to use the report feature in a timely manner to get staff to reject the fill or unfill the request if it did not meet the original voted on description. The other user may be fine with accepting something else, but other voters may not be and they should not be forced to accept that upload.
This should cover all the cases, the voters can have all of theirs done via a single PM thread if wanted too rather than mixing notifications and PM, but a PM will allow for updates to work nicer.
Upvote & Fund
The text was updated successfully, but these errors were encountered: