Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VisClean support for HERADataFastReader #849

Open
aewallwi opened this issue Dec 16, 2022 · 1 comment
Open

VisClean support for HERADataFastReader #849

aewallwi opened this issue Dec 16, 2022 · 1 comment
Assignees
@aewallwi

Comments

@aewallwi
Copy link
Collaborator

The VisClean object, which is our interface to all of our filters, does not currently support io.HERADataFastReader but a standard use-case is to load a small number of baselines across all times -- something that is vastly sped up by HERADataFastReader vs. HERAData.
@aewallwi aewallwi self-assigned this Dec 16, 2022
@aewallwi
Copy link
Collaborator Author

Since we are probably going to overhaul VisClean in the foreseeable future. I think it makes the most sense to hold off modifying VisClean and instead add a function to HERADataFastReader that converts to HERAData.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aewallwi aewallwi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aewallwi