Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of invalid cellIndices values #730

Open
psavery opened this issue Nov 15, 2024 · 2 comments
Open

Better handling of invalid cellIndices values #730

psavery opened this issue Nov 15, 2024 · 2 comments

Comments

@psavery
Copy link
Collaborator

psavery commented Nov 15, 2024

The cellIndices() function is used in the interpolation functions that we use for generating the polar view (for example, here).

However, sometimes nan values are produced within the function (as demonstrated in #729). These nan values, however, get converted to valid index values (like -1 or 0).

We should probably make sure we don't use invalid index values at all, rather than converting them to valid values.

Our best guess is that this bad handling of invalid cellIndices() values is resulting in bad interpolation values near detector borders. This is probably something that should be corrected.

@psavery
Copy link
Collaborator Author

psavery commented Nov 15, 2024

We should set up some tests to see what this is actually doing, and how it is affecting results.

@psavery
Copy link
Collaborator Author

psavery commented Dec 10, 2024

I tried looking into this. However, I could not reproduce the nan values. I'm not sure how they showed up. We should determine how they were showing up, and what we should do to fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant