Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-publish doesn't populate ig-registry description, authority, and country #937

Open
JohnMoehrke opened this issue Aug 7, 2024 · 3 comments
Assignees

Comments

@JohnMoehrke
Copy link
Contributor

go-publish is not filling out the ig-registry as completely as it does the feeds.
This might be happening only on a first publication. This might be only on IHE publications?

See description, authority, and country below.

    {
      "name": "IHE ITI Finance and Insurance Services",
      "category": "Financial",
      "npm-name": "ihe.iti.fais",
      "description": "??",
      "authority": "??",
      "country": "??",
      "history": "https://profiles.ihe.net/ITI/FAIS/history.html",
...
@JohnMoehrke
Copy link
Contributor Author

JohnMoehrke commented Aug 7, 2024

IGRegistryMaintainer.java

SHOULD add IHE to the following 2 functions.

  private String getCountry(String canonical) {
    if (canonical.contains("hl7.org")) {
      if (canonical.contains("/uv/"))
        return "uv";
      if (canonical.contains("/us/"))
        return "us";
    }
    return "??";
  }

  private String getAuthority(String canonical) {
    if (canonical.contains("hl7.org"))
      return "HL7";
    return "??";
  }

@JohnMoehrke
Copy link
Contributor Author

have not figured out the solution to the description, but it is set to "??" in IGRegistryMaintainer.java

@lmckenzi
Copy link
Contributor

We're not a fan of adding IHE. The country should come from the IG if it's not an HL7 IG that is either UV or US realm. (Perhaps it should come from the IG country always and just do a cross-check if it's HL7 or IHE UV/US?). The description should come from the publication request. Authority should be the IG publisher?

Also, 'contains("hl7.org")' is dangerous, as some are using things like "hl7.org.au" which would pass this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting for Input
Development

No branches or pull requests

3 participants