-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom Out Button Fails to Function Effectively in Playground #560
Comments
Right, I think I see this too. And in the console I see:
Investigating. |
Hmm. @9inpachi would you be free to chat about this at some point? I think you wrote it, and I'm a bit confused about the design - it kind of seems like tween and the following :
are clashing? Why do we need this callback, if tween is taking care of this? Also, when I let go of zoom in, it seems like |
Hey @EdwardMoyse, Sorry for getting back so late on this.
So it's coded this way because the tween doesn't run indefinitely with the mouse press. If we want to keep zooming in on the mouse's left button hold, then we need to create a tween for a smooth transition continuously until the user releases the mouse button. This is how it works.
That should be because of the multiple events being called. These exists so all different scenarios can be handled and the zoom animation can be canceled. |
Hi @9inpachi - thanks for the explanation ... I'm confused then why it doesn't work (for me it just glitches back and forth). I'll try to have another look. |
Fixed in #678 |
Description
During my exploration of Phoenix's playground, I encountered an issue with the zoom out button: it was not functioning properly. As a result, I had to manually zoom out using my mouse. This may be a bug that needs to be addressed.
Preview
screen-capture.webm
OS: Ubuntu 20.04.5
Node: 18.13.0
Browser: Google Chrome
Yarn: 3.3.1
The text was updated successfully, but these errors were encountered: