-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset cut is not updating view #689
Comments
I tried to debug this in: My idea was that we could use the To do this, I added a new method:
I also changed the html to also call the new method
But this does not work as I would expect:
My best guess is that this is because I'm invalidating the parent and not the child view. But I'm not sure what else to try... |
Hmm. I just noticed that _attachedToViewContainer is false for the ChangeDetectorRef... but not sure if this is relevant or not... |
@9inpachi @emiliocortina if either of you have any time to look at this I would be very grateful, because I'm pretty lost. |
I have published a pull request that I think fixes the issue. Please check and let me know, I'm a bit unfamiliar with the code I don't want to cause side effects... some of the commands were actually failing on my local setup (I was only able to run |
See:
https://github.com/user-attachments/assets/beb7359b-fa5a-4326-beff-38dddd8d3d5e
But basically, if you modify the cuts, then click 'Reset', the cut.model is updated but not the view (you get in the situation where you are turning a checkbox on, but it is already enabled by being reset)
This is WAY outside my comfort zone, but I wonder if the issue is in code like `` that we have:
whereas we should be using a two way binding, i.e. using
ngModel
Unfortunately this doesn't seem to work, so I guess it's not that easy....
Pinging @9inpachi and @emiliocortina, who also know WAY more about Angular than me....
The text was updated successfully, but these errors were encountered: