Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of CSS zoom and conditional CSS #114

Open
ghost opened this issue Jan 9, 2022 · 0 comments
Open

Get rid of CSS zoom and conditional CSS #114

ghost opened this issue Jan 9, 2022 · 0 comments

Comments

@ghost
Copy link

ghost commented Jan 9, 2022

basically title. originally we did this because the portal looks too small so we wanted to zoom in a bit, and without spending the time to reconfigure all the defaults (https://ant.design/docs/react/customize-theme).

however, it's sort of causing problems, because Cypress doesn't account for visibility of elements because it doesn't support css zoom but chrome does, and also the window bar looks wider than it should (adds horizontal scrollbar) on firefox, and we have conditional css everywhere...

in general, it's a huge pain, and we should get rid of it.

solution

honestly, not sure what the best thing to do is, so this might involve some research on your part. so far my ideas are:

  1. just make textsize bigger (however, this messes with proportions of antd components)
  2. fix above issue by reconfiguring all defaults from scratch (not sure if feasible)

in my opinion, you should go with the first one, and then just add styling where needed to make things look less ugly.

@ghost ghost added the tech debt label Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants