Save event times as local time #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinosher
requested changes
Oct 12, 2019
There was a problem hiding this comment.
I don't believe the fields you've added are valid as it's resulted in the file just containing "null".
You are right in assuming that I'm partial to the plugin calculating the offset though.
You can check what's been generated here: https://hacksocnotts-pr-101.herokuapp.com/calendar.ics
|
Hmm, that’s strange. I tried it locally and got the generated ics file without the ‘Z’ notation. |
|
My bad, the ics package needed an upgrade and I lost that in my first commit. Should work now. |
erinosher
approved these changes
Oct 14, 2019
erinosher
added a commit
that referenced
this pull request
Oct 17, 2019
This reverts commit c202f67.
DanielCordell
pushed a commit
that referenced
this pull request
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #90.
This solves the issues by saving the times as local time. Perhaps you wanted a different solution of saving them as UTC but with the correct offset?