-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hs.urlevent incorrectly treats scheme in case sensitive manner #3686
Comments
Looks like this is due to
|
Good spot, we are indeed doing a case-sensitive comparison:
|
(although note to anyone who might beat me to fixing this, actually the best place to do it would be in the Objective C side, by converting the scheme and host (but not the other fields) to lowercase: https://github.com/Hammerspoon/hammerspoon/blob/master/extensions/urlevent/liburlevent.m#L150 ) |
With Hammerspoon configured to be the default URL handler via URLDispatcher and trying to open a URL starting with "HTTPS://" I get the following error:
2024-09-10 13:14:11: 13:14:11 ERROR: urlevent: Hammerspoon has been passed a HTTPS URL, but does not know how to handle it
I.e. it looks like URLDispatcher treats "HTTPS" and "https" differently.
I believe, according to 6.2.2.1 of RFC 3986, schemes should be treated in a case-insensitive manner.
The text was updated successfully, but these errors were encountered: