Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimkey slows down textarea inputs on Github Pull Requests (large code reviews) even when disabled #29

Open
aubreypwd opened this issue Aug 16, 2023 · 1 comment

Comments

@aubreypwd
Copy link

aubreypwd commented Aug 16, 2023

When viewing the files of a large PR e.g. github.com/org/repo/pull/*/files the commenting input's are impossible to use even with the page "disabled" in Vimkey using REGEX, ^(.*)/pull/(.*)/files(.*)? which shows it is disabled:

CleanShot 2023-08-16 at 08 33 35@2x

If I completely disable the extension the textarea input's are useable again:

CleanShot.2023-08-16.at.08.35.45-converted.mp4

I would have assumed that disabling Vimkey for that page would have solved the issue, but it did not. I am also assuming that the fact this PR was so large may be a factor, but I have not yet tested this on a smaller pull request.

@Haojen
Copy link
Owner

Haojen commented Aug 16, 2023

@aubreypwd Thank you feedback, the video is very useful, and I will follow the video to test the disable rules, and I will fix it as soon as possible. when I fix it I'll let you know here.
thank you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants