Updating to latest SDK

[mastef]

Any chances of updating the android version to the latest SDK? It comes with some fixes for Samsung devices that we ran into, and adds Chrome Custom Tabs ( so if the user is logged in in Chrome, he won't be prompted to enter his details / password )

Or any hints how to attempt to update it? ( Tried with replacing build.gradle + java directory, but no luck )

[mastef]

@TBaudon I was successful in updating the FB SDK to the latest version - are you interested in a PR?

1. As I'm working on the legacy branch, it might be interesting to merge the 2 branches first based on a conditional flag as mentioned in Undefined symbols for arm64 SDLUIKitDelegate #6 - e.g. #if lime_legacy ... #else ...#end. This way both branches would be up-to-date right away and people don't have to switch between git repos when installing this extension
2. Instead of adding the android-support-v4.jar to the repo, it might be better to just add haxelib dependancy on this project :
   https://github.com/openfl/extension-android-support-v4
   ( same way as e.g. https://github.com/SempaiGames/extension-googleplaygames/blob/master/haxelib.json does )
3. There's 2 new dependencies in the facebook android SDK : android-support-cardview.jar and android-support-customtabs.jar. If this PR and 2. are interesting, I could create haxelib repos for those 2 so they can be included through dependencies.
4. It might be better to address the facebook SDK's git repo instead through git module or git subtree instead. So it can be kept updated right away, without having to manually copy/paste rebuild it every time.

[Tomobodo]

Hello, thanks for your help and advice, a pull request would be great !

I'll check what I can do about those two branch.
As you said I probably can do something with the "#if lime_legacy" define.

In the objective-c code, there is two categories : one that upgrade the SDL backend and one that upgrade the lime backend for legacy user.
The code is almost the same, only the function signature change from "sdl-**" to "lime-" if i remember correctly.

I could check in the hxcpp'x build.xml if there is a way to compile a specific class based on what define are used. Or use those define directly in the objective-c code and use only one class for sdl and lime.

This way instead of using a branch , we could just rebuild the extension using "lime rebuild facebook -dLegacy" or something like that.

[mastef]

It's not really a lot of changes right? Mostly this commit or is there anything more? f0cdbad

I think in LoginWrapper.mm possibly there'd be a need for a initLoginLegacy version?

Here's one tut that shows how to distinguish between legacy and non legacy for ios http://blog.zame-dev.org/openfl-extension-in-10-steps/ maybe this would help :

    <target id="default">
        <target id="ndll" if="ios" unless="legacy" />
        <target id="ndll-legacy" if="ios legacy" />
    </target>

[mastef]

I was preparing the PR, but since I'm working with the legacy branch that'd be a bit messy. I guess first we should merge branches