Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method loadPlayerImage doesn't exist #31

Open
mastef opened this issue Jan 26, 2017 · 3 comments
Open

method loadPlayerImage doesn't exist #31

mastef opened this issue Jan 26, 2017 · 3 comments

Comments

@mastef
Copy link

mastef commented Jan 26, 2017

The readme mentions a use-case for loadPlayerImage, however that method doesn't seem to exist

@mastef
Copy link
Author

mastef commented Jan 26, 2017

I think it should be getPlayerImage instead

@mastef
Copy link
Author

mastef commented Jan 26, 2017

In the same breath, the whole getPlayerImage() and loadConnectedPlayers() logic might work better if a specific callback would be defined when calling it, instead of having one centralised callback that's always called, no matter which request.

Also handling failures on both loading friends and loading pictures would be great. Right now the app doesn't know if the request failed, nor why.

@mastef
Copy link
Author

mastef commented Jul 3, 2017

I've added a PR #34 for the loading pictures failure callback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant