Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDR for rectangular matrices. #6

Open
ashim95 opened this issue Nov 9, 2021 · 1 comment
Open

LDR for rectangular matrices. #6

ashim95 opened this issue Nov 9, 2021 · 1 comment

Comments

@ashim95
Copy link

ashim95 commented Nov 9, 2021

Hi @tridao ,

Thanks for this implementation.

Everywhere in the code I notice that the weight matrices are assumed to be square. Did you guys perform any experiments with rectangular matrices?

Or, Do you have any reference for an LDR implementation for rectangular matrices?

Thank you,

@albertfgu
Copy link
Contributor

I believe that we didn't use rectangular matrices, and I don't know of a proper implementation of LDR for rectangular matrices.
If we did use rectangular matrices, we probably would have just created a larger square matrix and truncate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants