Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully implement pluralization (language rule 4) #221

Open
jleclanche opened this issue Mar 24, 2018 · 6 comments
Open

Fully implement pluralization (language rule 4) #221

jleclanche opened this issue Mar 24, 2018 · 6 comments
Labels
bug Something isn't working

Comments

@jleclanche
Copy link
Member

jleclanche commented Mar 24, 2018

Followup on #220. The text no longer looks weird, but pluralization is incorrect.

Until this is fixed we will be incorrectly displaying the text of some cards in some languages, such as Swipe in French.

Note: Unlikely to happen in Joust. I suspect we'll do it in Sunwell and by the time we do it, we'll switch to that.

@beheh beheh added the bug Something isn't working label May 22, 2018
@joolean
Copy link
Contributor

joolean commented Jul 5, 2018

@jleclanche Can you clarify what the work to be done here is?

@jleclanche
Copy link
Member Author

jleclanche commented Jul 5, 2018

This ticket is to implement card pluralization rules (|4 ...) which right now, althought they're parsed in Joust, they don't actually pluralize correctly (we don't bother parsing the number, we always assume it's plural IIRC).

The most likely fix is to switch to Sunwell for card rendering, which does have it implemented.

@joolean
Copy link
Contributor

joolean commented Jul 5, 2018

My understanding was the Sunwell was too slow to use in Joust. Has that changed?

@jleclanche
Copy link
Member Author

It has not. There's a lot of performance work to do before we can use one inside the other.

@joolean
Copy link
Contributor

joolean commented Jul 5, 2018

In that case, I think we should fix this in Joust, running the risk that the work is rendered unnecessary if we for some reason prioritize Sunwell performance improvements.

@jleclanche
Copy link
Member Author

I'm fine with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants