Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply quotation format bug. #114

Open
leftside2 opened this issue Mar 9, 2018 · 9 comments
Open

Reply quotation format bug. #114

leftside2 opened this issue Mar 9, 2018 · 9 comments

Comments

@leftside2
Copy link

leftside2 commented Mar 9, 2018

Original text:
> hello
>> hi
> where are u from?
>> I'm from Mars.

Converted result: (after hit Enter)

hello

hi
where are u from?
I'm from Mars.

To bypass the bug:
> hello
>> hi
.
> where are u from?
>> I'm from Mars.

@ghost
Copy link

ghost commented Mar 9, 2018

I don't think this is a bug. New lines always go into the blockquote unless there's two new lines - I believe this is in the CommonMark spec, and GitHub also behaves this way. For example:

> test
still inside blockquote

will have that second line still inside the blockquote. Whereas:

> test

not inside blockquote

Putting two new lines will make the line not inside the blockquote.

In your case, you only have one new line after the first inner blockquote, so all of the lines are inside it.

@leftside2
Copy link
Author

@krixano : So do you mean that if someone think it's ridiculous he has to ask CommonMark staff? Any room for ZeroMe developer has something to do with this matter?

@ghost
Copy link

ghost commented Mar 9, 2018

@leftside2 I was merely saying it's not a bug but that it's intended as per the standard. Nofish will be able to fix this, but chances are he's using a library for this - so he'll have to change that library.

Also, I disagree that this should be changed based on consistency reasons. Exception: If this were to be changed, then I propose that the rule where two new lines must be after ">" to break off from the blockquote be changed to just one new line (which would mean every line part of the blockquote must have ">"), also for consistency reasons.

However, I don't think this should be changed because ever zite that uses markdown probably acts in the same way as I described. It's better to keep everything consistent, imo.

@leftside2
Copy link
Author

@krixano : I see. :) One question. Plz answer. In ZeroMe, In the new post box, by pressing SHIFT-ENTER you can feed new line without submitting the post. But in the comment box under the post this key combination doesn't work. In my case, I click [reply] button on the other comments to feed the new line and erase the ID part to make use of the new line. How do u do to do this?

@HelloZeroNet
Copy link
Owner

HelloZeroNet commented Mar 9, 2018

tab, enter should work. (maybe we should remove the comment sending by enter to make it consistent)

@leftside2
Copy link
Author

@HelloZeroNet : Thanks! Why don't u put a [?] icon beneath the test editing box?

@leftside2
Copy link
Author

@HelloZeroNet : tab, enter doesn't work. :(

@HelloZeroNet
Copy link
Owner

I just tried and it's works, to posting on ZeroMe

@leftside2
Copy link
Author

@HelloZeroNet : I mean the reply edit box, not new post. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants