Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing should not depend on std #26

Open
HeroicKatora opened this issue Oct 26, 2019 · 0 comments
Open

Parsing should not depend on std #26

HeroicKatora opened this issue Oct 26, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@HeroicKatora
Copy link
Owner

HeroicKatora commented Oct 26, 2019 •
edited
Loading

There are some instances where parsing of structs (core::str::FromStr) makes use of the implementations provided by the standard library. Problematically, these are defined in std and not in core such that this depends on the std feature. This makes the trait implementations inconsistent and makes the dependency quite a lot heavier.

Instead, such parsing should be implemented in a standalone version (possibly with a dedicated, small dependency).
@HeroicKatora HeroicKatora added enhancement New feature or request good first issue Good for newcomers labels Oct 26, 2019
HeroicKatora added a commit that referenced this issue Oct 26, 2019
@HeroicKatora
Fix example feature dependencies
382f516 
Turns out that all features rely on std, not only sys, in some capacity.
Most of the failures are from parsing of address which is implemented in
terms of std (see #26).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HeroicKatora