New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate whether `TO-DO: Inject Environment variables for reviewer group names` is relevant #8

Open

manics opened this issue Jun 28, 2023 · 0 comments

Assignees

Member

manics commented Jun 28, 2023

As mentioned in https://github.com/HicResearch/treehoose-egress-app-backend/pull/7/files#r1244934201
there's this todo:

treehoose-egress-app-backend/egress_backend/lambda/egress_api/update_request.py

Line 82 in dae1c9d

# TO-DO: Inject Environment variables for reviewer group names

presumably the group names are stored somewhere configurable? If so, this todo doesn't make sense anymore?

manics self-assigned this

manics mentioned this issue

Use convert_bool consistently, use relative Python imports, fix SSO groups #7

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment