Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host docs for PRs #2107

Open
Alizter opened this issue Oct 4, 2024 · 3 comments
Open

Host docs for PRs #2107

Alizter opened this issue Oct 4, 2024 · 3 comments

Comments

@Alizter
Copy link
Collaborator

Alizter commented Oct 4, 2024

I think it would be beneficial for the CI to deploy docs from PRs so that PR authors can easily inspect the result without having to build the docs locally, which can require configuring CSS, or having to wait for the PR to be merged into master.

@jdchristensen
Copy link
Collaborator

It seems to work fine for me to build the docs locally and just view them in a browser, with no server. Maybe we just need to document this in STYLE.md?

@Alizter
Copy link
Collaborator Author

Alizter commented Oct 4, 2024

I think maybe alectryon had some weird CSS issues then I don't recall. The point is we ought to be able to see it all from the CI.

@Alizter
Copy link
Collaborator Author

Alizter commented Oct 4, 2024

I think documenting it in STYLE.md would be a good idea. I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants