Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing error when 2fa page on subdomain #151

Open
dachinat opened this issue Jul 24, 2018 · 1 comment
Open

Routing error when 2fa page on subdomain #151

dachinat opened this issue Jul 24, 2018 · 1 comment

Comments

@dachinat
Copy link

Let's say you have set-up two factor authentication on sub-domain "admin.example.com"

Scenario:
Log-in to get prompted for 2nd factor code
Don't enter your code, navigate to "example.com" without subdomain
You'll get a routing error. Gem tries to show 2nd factor form page.

Possible fix:

Replace path with url in two_factor_authentication/controllers/helpers.rb:33

change_path = "#{scope}_two_factor_authentication_url"

@dachinat
Copy link
Author

This PR solves such issues in a different way #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant