From 26783ae166c21b761e7551283ad6931c9a25bb6f Mon Sep 17 00:00:00 2001 From: Branden Rodgers Date: Wed, 18 Dec 2024 17:36:45 -0500 Subject: [PATCH] chore: Fix project upload link (#1311) --- lib/projects/buildAndDeploy.ts | 4 ++-- lib/projects/upload.ts | 14 ++++++++------ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/lib/projects/buildAndDeploy.ts b/lib/projects/buildAndDeploy.ts index 118577b22..1a1960f7f 100644 --- a/lib/projects/buildAndDeploy.ts +++ b/lib/projects/buildAndDeploy.ts @@ -82,7 +82,7 @@ type PollTaskStatusFunctionConfig = { accountId: number, taskName: string, taskId: number, - deployedBuildId: number + deployedBuildId: number | null ) => void; }; @@ -118,7 +118,7 @@ function makePollTaskStatusFunc({ ) { const displayId = deployedBuildId || taskId; - if (linkToHubSpot && !silenceLogs && deployedBuildId) { + if (linkToHubSpot && !silenceLogs) { logger.log( `\n${linkToHubSpot(accountId, taskName, taskId, deployedBuildId)}\n` ); diff --git a/lib/projects/upload.ts b/lib/projects/upload.ts index 2f2efb5d7..98068259d 100644 --- a/lib/projects/upload.ts +++ b/lib/projects/upload.ts @@ -53,12 +53,14 @@ async function uploadProjectFiles( }), }); - logger.debug( - i18n(`${i18nKey}.uploadProjectFiles.buildCreated`, { - buildId, - projectName, - }) - ); + if (buildId) { + logger.debug( + i18n(`${i18nKey}.uploadProjectFiles.buildCreated`, { + buildId, + projectName, + }) + ); + } } catch (err) { SpinniesManager.fail('upload', { text: i18n(`${i18nKey}.uploadProjectFiles.fail`, {