Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advice requested: HTTP client metrics #141

Open
lightbody opened this issue Jan 21, 2020 · 1 comment
Open

Advice requested: HTTP client metrics #141

lightbody opened this issue Jan 21, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@lightbody
Copy link
Contributor

Hi there. We're using the Micronaut framework, which has it's own HTTP client and ExecutorService, both of which get nice metrics sent out to our prometheus setup.

This project seems to fall back to it's own ExecutorService + Ning's HTTP client, and as a result I don't have as much visibility when things so sideways.

Do you have any advice on how I should solve this? For another project, I had a place where I could plug in my own HTTP client wrapper + ExecutorService and that worked well. But here it doesn't look like that is the case, though I could be misreading the code.

@szabowexler
Copy link
Collaborator

Hmmm. That's an interesting request -- you're right, when we ported this project from internal at HubSpot to OSS, we basically ripped out a hybrid wrapper for the http framework we use and bundled it to speed up release. I think allowing people to supply their own http client would be a pretty solid improvement to the API.

I suspect a short term fix would be improving the metrics collected (it's a bit weak here), and a longer term solution would be an improvement to the API that lets you provide your own execution environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants