Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean fields are not deserialized into SlackUser model #181

Open
omotnyk opened this issue Jul 13, 2020 · 0 comments
Open

Boolean fields are not deserialized into SlackUser model #181

omotnyk opened this issue Jul 13, 2020 · 0 comments

Comments

@omotnyk
Copy link
Contributor

omotnyk commented Jul 13, 2020

Describe the bug
We noticed that Optional<Boolean> values are not deserialized correctly into SlackUser. For example, Slack sends user with key is_bot but we expect bot due to the Jackson deserialization logic which works like that for isBot methods. We need to add get prefix to those methods to fix deserialization or specify key via @JsonProperty. The second option seems better as there are already some usages of the methods.
#180

To Reproduce
Steps to reproduce the behavior:

  1. Try to deserialize SlackUser.
  2. See that no fields with isXxx getter are deserialized.

Expected behavior
All the fields with isXxx getter are deserialized correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant