From 595833ac2c56de0f6ed248e72141be1661d50eaa Mon Sep 17 00:00:00 2001
From: Sergey Yeranosyan <syeranosyan@hubspot.com>
Date: Wed, 31 Jul 2024 09:44:29 +0400
Subject: [PATCH] Added metrics for successfully published messages

---
 pom.xml                                       |  4 +-
 slack-java-client/pom.xml                     |  8 +++
 .../hubspot/slack/client/SlackWebClient.java  | 49 +++++++++++++++++++
 3 files changed, 59 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index b437aee0..0a70210f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -4,8 +4,8 @@
 
   <parent>
     <groupId>com.hubspot</groupId>
-    <artifactId>basepom</artifactId>
-    <version>59.9</version>
+    <artifactId>parent-pom</artifactId>
+    <version>1.0-SNAPSHOT</version>
   </parent>
 
   <groupId>com.hubspot.slack</groupId>
diff --git a/slack-java-client/pom.xml b/slack-java-client/pom.xml
index 09ddedcc..1a218cf1 100644
--- a/slack-java-client/pom.xml
+++ b/slack-java-client/pom.xml
@@ -31,6 +31,14 @@
       <groupId>com.google.guava</groupId>
       <artifactId>guava</artifactId>
     </dependency>
+    <dependency>
+      <groupId>com.yammer.metrics</groupId>
+      <artifactId>metrics-core</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>com.hubspot.utils</groupId>
+      <artifactId>hubspot-context</artifactId>
+    </dependency>
 
     <!-- temporary -->
     <dependency>
diff --git a/slack-java-client/src/main/java/com/hubspot/slack/client/SlackWebClient.java b/slack-java-client/src/main/java/com/hubspot/slack/client/SlackWebClient.java
index c4a90b80..1b4be9ba 100644
--- a/slack-java-client/src/main/java/com/hubspot/slack/client/SlackWebClient.java
+++ b/slack-java-client/src/main/java/com/hubspot/slack/client/SlackWebClient.java
@@ -184,6 +184,10 @@
 import com.hubspot.slack.client.paging.LazyLoadingPage;
 import com.hubspot.slack.client.ratelimiting.ByMethodRateLimiter;
 import com.hubspot.slack.client.ratelimiting.SlackRateLimiter;
+import com.hubspot.utils.hubspot.context.HubSpotContext;
+import com.hubspot.utils.hubspot.context.PlatformProperties;
+import com.yammer.metrics.Metrics;
+import com.yammer.metrics.core.MetricName;
 import java.io.File;
 import java.io.IOException;
 import java.util.Collections;
@@ -211,6 +215,11 @@ public class SlackWebClient implements SlackClient {
     .setObjectMapper(ObjectMapperUtils.mapper())
     .build();
   private static final AtomicLong REQUEST_COUNTER = new AtomicLong(0);
+  private static final String UNKNOWN = "UNKNOWN";
+  private static final String METRIC_NAME = "SLACK_NOTIFICATIONS";
+  private static final String DEPLOYABLE_NAME_TAG = "DEPLOYABLE_NAME";
+  private static final String HUB_SPOT_TEAM_TAG = "HUB_SPOT_TEAM";
+  private static final String SLACK_MESSAGE_TAG = "SLACK_MESSAGE";
 
   private final NioHttpClient nioHttpClient;
   private final CloseableExecutorService recursingExecutor;
@@ -1766,6 +1775,7 @@ private <T extends SlackResponse> Result<T, SlackError> parseSlackResponse(
     JsonNode responseJson = response.getAsJsonNode();
     boolean isOk = responseJson.get("ok").asBoolean();
     if (isOk) {
+      publishMetrics(request);
       return Result.ok(
         ObjectMapperUtils.mapper().treeToValue(responseJson, responseType)
       );
@@ -1780,6 +1790,45 @@ private <T extends SlackResponse> Result<T, SlackError> parseSlackResponse(
     );
   }
 
+  private void publishMetrics(final HttpRequest request) {
+    ImmutableMap<String, String> tags = buildMetrics(request);
+    if (!tags.isEmpty()) {
+      incrementMetrics(tags);
+    }
+  }
+
+  private void incrementMetrics(final ImmutableMap<String, String> tags) {
+    try {
+      Metrics.newCounter(new MetricName(SlackWebClient.class, METRIC_NAME, tags)).inc();
+    } catch (Exception ex) {
+      LOG.warn("Failed to increment metric with name {}.", METRIC_NAME, ex);
+    }
+  }
+
+  private ImmutableMap<String, String> buildMetrics(HttpRequest request) {
+    try {
+      PlatformProperties platformProperties = HubSpotContext
+        .current()
+        .getPlatformProperties();
+      LOG.info("Building metrics for platform properties {}", platformProperties);
+      return ImmutableMap
+        .<String, String>builder()
+        .put(DEPLOYABLE_NAME_TAG, platformProperties.getDeployable().orElse(UNKNOWN))
+        .put(HUB_SPOT_TEAM_TAG, platformProperties.getHubSpotTeam().orElse(UNKNOWN))
+        .put(
+          SLACK_MESSAGE_TAG,
+          Optional
+            .ofNullable(request.getBody(ObjectMapperUtils.mapper()))
+            .map(String::new)
+            .orElse(UNKNOWN)
+        )
+        .build();
+    } catch (Exception ex) {
+      LOG.warn("Failed to build metrics for request {}", request, ex);
+      return ImmutableMap.of();
+    }
+  }
+
   private <T extends SlackResponse> CompletableFuture<Result<T, SlackError>> postSlackCommandUrlEncoded(
     SlackMethod method,
     Multimap<String, String> params,