Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis does not populate file_core.file_source #39

Open
hannes-ucsc opened this issue Aug 31, 2021 · 0 comments
Open

Analysis does not populate file_core.file_source #39

hannes-ucsc opened this issue Aug 31, 2021 · 0 comments

Comments

@hannes-ucsc
Copy link
Collaborator

hannes-ucsc commented Aug 31, 2021

The spec requires Analysis to set the provenance.submitter_id on project-level matrices. The use of provenance.submitter_id was a hack to work around the lack (at the time the spec was written) of a suitable schema property to identify the origin of a file.

We now have file_core.file_source and DCP/2 Analysis should populate it, not only for matrices but in all …_file entities it emits. It should be set to DCP/2 Analysis, one of the valid enum values for that property.

To ensure a smooth transition, Analysis should continue to populate provenance.submitter_id for backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant