Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't tell from TDR's responses whether snapshot is public #56

Open
hannes-ucsc opened this issue Dec 10, 2021 · 0 comments
Open

Can't tell from TDR's responses whether snapshot is public #56

hannes-ucsc opened this issue Dec 10, 2021 · 0 comments
Labels
orange [process] Done by the Azul team

Comments

@hannes-ucsc
Copy link
Collaborator

For DataBiosphere/data-browser#1662 we need to determine if a snapshot is public. We originally planned on doing this by making two enumerateSnapshots requests, one with the credentials of a service account (the public SA) that has no special permissions in TDR and another one with those of the service account that has access to all snapshots (the indexer SA). From the difference between the two responses we planned to infer which snapshots are public. The original plan turns out to also be complicating our code and making it inefficient.

I think TDR should include a boolean property on both enumerateSnapshots and retrieveSnapshot that is True for public snapshots. Knowing whether a snapshot is public should not have to be inferred by triangulating with requests from different identities. An identity (user, service account) that has special access to non-public snapshots should be able to tell from the TDR response whether a snapshot is accessible to them because it is a non-public snapshot to which they have explicit access, or because it is public.

Assuming that the public status of a snapshot is easily retrievable and does not require additional round-trips to the backend database, this should be easy to implement.

@hannes-ucsc hannes-ucsc changed the title TDR's enumerateSnapshots and retrieveSnapshot responses lack public status Can't tell from TDR's responses whether snapshot is public Dec 10, 2021
@melainalegaspi melainalegaspi added the orange [process] Done by the Azul team label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orange [process] Done by the Azul team
Projects
None yet
Development

No branches or pull requests

2 participants