Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hazard Provider to compute Total Water Level #4

Open
HenryGeorgist opened this issue Nov 24, 2021 · 4 comments
Open

Update Hazard Provider to compute Total Water Level #4

HenryGeorgist opened this issue Nov 24, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@HenryGeorgist
Copy link
Member

h.SetDepth(swls[i])

For the coastal damage functions we need to have the depth variable in the damage function lookup be
TWL = SWL + 0.71.6Hm0
and wave height needs to be
Hc = 1.6*Hm0

But technically this should only apply if the damage function comes from the fema logically consistent set.

there are a few things we could do here.
we could add a new variable to the hazard (Total Water Level) so that SWL can be used for non wave damage functions.
the compute of the depth could be pushed into go consequences, if the hazard has wave height and the occupancy type is of a certain type...

@HenryGeorgist HenryGeorgist added the bug Something isn't working label Nov 24, 2021
@trietmnj
Copy link

So only the depth calculations would go into go-consequences and all the other hazard pieces in go-coastal? If we have only just started, it would make sense to have a middleware layer to take care of any hazard data generation.

@trietmnj
Copy link

Either way, if we want to continue relegating the wave damage selection to the backend, we would need some way to distinguish whether the alternative formulation would be warranted. Maybe adding another variable to each function to document its source?

@HenryGeorgist
Copy link
Member Author

well go-coastal (this project) is really the "middleware" here. We do actually have access to the occupancy type when we run the compute here, so we could actually put all of the logic in the go-coastal project

@HenryGeorgist
Copy link
Member Author

there is an open issue in go-consequences to add a source variable to the damage function. i feel like that is a fairly simple use case, and it might be releavant to add a "damage driving parameter" variable too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants