From 4c3861ae1f44449a652b88c6776f0430d0f0cc11 Mon Sep 17 00:00:00 2001
From: PiotrAniola82 <piotr.aniola@ibm.com>
Date: Thu, 19 Dec 2024 13:19:31 +0100
Subject: [PATCH 1/2] Don't display the GC chart if there are no verbosegc
 files

Signed-off-by: PiotrAniola82 <piotr.aniola@ibm.com>
---
 .../data/jquery/wait2scripts.js               |  4 +-
 src/javacore_analyser/data/xml/report.xsl     | 46 +++++++++++--------
 2 files changed, 30 insertions(+), 20 deletions(-)

diff --git a/src/javacore_analyser/data/jquery/wait2scripts.js b/src/javacore_analyser/data/jquery/wait2scripts.js
index 4f3ae30..0dbcf1f 100644
--- a/src/javacore_analyser/data/jquery/wait2scripts.js
+++ b/src/javacore_analyser/data/jquery/wait2scripts.js
@@ -99,7 +99,9 @@ const loadChartGC = function() {
   }
 
   const sysResourceE3Elem = document.getElementById('systemresources_myChartGC');
-  sysResourceE3Elem.classList.remove('hide');
+  if (sysResourceE3Elem) {
+    sysResourceE3Elem.classList.remove('hide');
+  }
 
   const ctx = document.getElementById('myChartGC');
 
diff --git a/src/javacore_analyser/data/xml/report.xsl b/src/javacore_analyser/data/xml/report.xsl
index af92f90..df49d47 100644
--- a/src/javacore_analyser/data/xml/report.xsl
+++ b/src/javacore_analyser/data/xml/report.xsl
@@ -355,25 +355,33 @@
                             <h4>Garbage Collection Activity</h4>
                             <a id="togglememusagedoc" href="javascript:expand_it(memusagedoc,togglememusagedoc)" class="expandit">
                                 What does this chart tell me?</a>
-                            <div id="memusagedoc" style="display:none;">
-                                This chart shows all the garbage collections that happened between the time
-                                of the first and the last javacore in the data set.
-                                Garbage collections that happened before the first
-                                or after the last javacore generation time are not included.
-                                <ul>
-                                    <li><strong>Heap Usage</strong>
-                                        is the available Java heap memory over time,
-                                        based on the garbage collection data from the verbose GC log files.
-                                    </li>
-                                    <li><strong>Total Heap</strong>
-                                        is the maximum size of the Java heap, configured by using the Xmx Java argument,
-                                        expressed in megabytes.
-                                    </li>
-                                </ul>
-                            </div>
-                            <div id="systemresources_myChartGC" class="chart-container hide">
-                                <canvas id="myChartGC" height="200"></canvas>
-                            </div>
+                                <xsl:choose>
+                                    <xsl:when test="doc/report_info/verbose_gc_list/verbose_gc">
+                                        <div id="memusagedoc" style="display:none;">
+                                            This chart shows all the garbage collections that happened between the time
+                                            of the first and the last javacore in the data set.
+                                            Garbage collections that happened before the first
+                                            or after the last javacore generation time are not included.
+                                            <ul>
+                                                <li><strong>Heap Usage</strong>
+                                                    is the available Java heap memory over time,
+                                                    based on the garbage collection data from the verbose GC log files.
+                                                </li>
+                                                <li><strong>Total Heap</strong>
+                                                    is the maximum size of the Java heap, configured by using the Xmx Java argument,
+                                                    expressed in megabytes.
+                                                </li>
+                                            </ul>
+                                        </div>
+                                        <div id="systemresources_myChartGC" class="chart-container hide">
+                                            <canvas id="myChartGC" height="200"></canvas>
+                                        </div>
+                                    </xsl:when>
+                                    <xsl:otherwise>
+                                        <br/>
+                                        No verbosegc logs were provided
+                                    </xsl:otherwise>
+                                </xsl:choose>
                             <h4>CPU Load</h4>
                             <a id="togglecpuloaddoc" href="javascript:expand_it(cpuloaddoc,togglecpuloaddoc)" class="expandit">
                                 What does this chart tell me?</a>

From f053bbcca7fe9818f8b75ea189688f75e193e5d3 Mon Sep 17 00:00:00 2001
From: PiotrAniola82 <piotr.aniola@ibm.com>
Date: Thu, 19 Dec 2024 14:37:02 +0100
Subject: [PATCH 2/2] Don't display the GC chart if there are no collections
 within javacore time limits

Signed-off-by: PiotrAniola82 <piotr.aniola@ibm.com>
---
 .../data/jquery/wait2scripts.js               |  2 +-
 src/javacore_analyser/data/xml/report.xsl     | 36 +++++++++++--------
 src/javacore_analyser/javacore_set.py         |  4 +++
 src/javacore_analyser/verbose_gc.py           |  1 -
 4 files changed, 27 insertions(+), 16 deletions(-)

diff --git a/src/javacore_analyser/data/jquery/wait2scripts.js b/src/javacore_analyser/data/jquery/wait2scripts.js
index 0dbcf1f..e2a9c84 100644
--- a/src/javacore_analyser/data/jquery/wait2scripts.js
+++ b/src/javacore_analyser/data/jquery/wait2scripts.js
@@ -127,7 +127,7 @@ const loadChartGC = function() {
        startingPoint = timestamp;
 
     if(endingPoint < timestamp)
-        endingPoint > timestamp;
+        endingPoint = timestamp;
   }
 
   coresTimeRange['startTime'] = startingPoint;
diff --git a/src/javacore_analyser/data/xml/report.xsl b/src/javacore_analyser/data/xml/report.xsl
index df49d47..8aa9aa0 100644
--- a/src/javacore_analyser/data/xml/report.xsl
+++ b/src/javacore_analyser/data/xml/report.xsl
@@ -357,25 +357,33 @@
                                 What does this chart tell me?</a>
                                 <xsl:choose>
                                     <xsl:when test="doc/report_info/verbose_gc_list/verbose_gc">
-                                        <div id="memusagedoc" style="display:none;">
-                                            This chart shows all the garbage collections that happened between the time
-                                            of the first and the last javacore in the data set.
-                                            Garbage collections that happened before the first
-                                            or after the last javacore generation time are not included.
-                                            <ul>
-                                                <li><strong>Heap Usage</strong>
-                                                    is the available Java heap memory over time,
-                                                    based on the garbage collection data from the verbose GC log files.
-                                                </li>
-                                                <li><strong>Total Heap</strong>
-                                                    is the maximum size of the Java heap, configured by using the Xmx Java argument,
-                                                    expressed in megabytes.
-                                                </li>
+                                        <xsl:choose>
+                                            <xsl:when test="//verbose_gc_list/@total_collects_in_time_limits = 0">
+                                                <br/>
+                                                There were no garbage collections withing the javacore time limits
+                                            </xsl:when>
+                                            <xsl:otherwise>
+                                                <div id="memusagedoc" style="display:none;">
+                                                This chart shows all the garbage collections that happened between the time
+                                                of the first and the last javacore in the data set.
+                                                Garbage collections that happened before the first
+                                                or after the last javacore generation time are not included.
+                                                <ul>
+                                                    <li><strong>Heap Usage</strong>
+                                                        is the available Java heap memory over time,
+                                                        based on the garbage collection data from the verbose GC log files.
+                                                    </li>
+                                                    <li><strong>Total Heap</strong>
+                                                        is the maximum size of the Java heap, configured by using the Xmx Java argument,
+                                                        expressed in megabytes.
+                                                    </li>
                                             </ul>
                                         </div>
                                         <div id="systemresources_myChartGC" class="chart-container hide">
                                             <canvas id="myChartGC" height="200"></canvas>
                                         </div>
+                                            </xsl:otherwise>
+                                        </xsl:choose>
                                     </xsl:when>
                                     <xsl:otherwise>
                                         <br/>
diff --git a/src/javacore_analyser/javacore_set.py b/src/javacore_analyser/javacore_set.py
index 7bc60b4..f343ca6 100644
--- a/src/javacore_analyser/javacore_set.py
+++ b/src/javacore_analyser/javacore_set.py
@@ -383,6 +383,8 @@ def __create_report_xml(self, output_file):
 
         verbose_gc_list_node = self.doc.createElement("verbose_gc_list")
         report_info_node.appendChild(verbose_gc_list_node)
+
+        total_collects_in_time_limits = 0
         for vgc in self.gc_parser.get_files():
             verbose_gc_node = self.doc.createElement("verbose_gc")
             verbose_gc_list_node.appendChild(verbose_gc_node)
@@ -392,9 +394,11 @@ def __create_report_xml(self, output_file):
             verbose_gc_collects_node = self.doc.createElement("verbose_gc_collects")
             verbose_gc_node.appendChild(verbose_gc_collects_node)
             verbose_gc_collects_node.appendChild(self.doc.createTextNode(str(vgc.get_number_of_collects())))
+            total_collects_in_time_limits += vgc.get_number_of_collects()
             verbose_gc_total_collects_node = self.doc.createElement("verbose_gc_total_collects")
             verbose_gc_node.appendChild(verbose_gc_total_collects_node)
             verbose_gc_total_collects_node.appendChild(self.doc.createTextNode(str(vgc.get_total_number_of_collects())))
+        verbose_gc_list_node.setAttribute("total_collects_in_time_limits", str(total_collects_in_time_limits))
 
         system_info_node = self.doc.createElement("system_info")
         doc_node.appendChild(system_info_node)
diff --git a/src/javacore_analyser/verbose_gc.py b/src/javacore_analyser/verbose_gc.py
index 5735d9c..5d11a0b 100644
--- a/src/javacore_analyser/verbose_gc.py
+++ b/src/javacore_analyser/verbose_gc.py
@@ -154,7 +154,6 @@ def set_number_of_collects(self, number):
     gets the total number of gc collections in this VerboseGcFile
     regardless of the time when tey occurred with regards to the javacores
     '''
-
     def get_total_number_of_collects(self):
         if self.__total_number_of_collects < 0:
             self.get_collects()