Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apps that use an rclone config may not be down-able #249

Open
starpit opened this issue Sep 10, 2024 · 1 comment
Open

fix: apps that use an rclone config may not be down-able #249

starpit opened this issue Sep 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@starpit
Copy link
Member

starpit commented Sep 10, 2024

Describe the bug
If the rclone config file in question used for up is not available on the machine doing down, then the down will fail. This is because down depends on templating the application into the llir, in order to know which resources to delete. And the templating step looks for the rclone config file...

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@starpit starpit added the bug Something isn't working label Sep 10, 2024
@starpit
Copy link
Member Author

starpit commented Sep 10, 2024

one fix would be to have down instead just kill all runname-labeled resources. we could leverage the GetAllResourcesFromSelector from odo. https://github.com/redhat-developer/odo/blob/main/pkg/kclient/all.go

alternatively, we could somehow render rclone config file loading into warnings when doing down...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant